Skip to content

Create a git submodule setup#2

Merged
Zetison merged 8 commits intomainfrom
feat/submodules
Apr 9, 2025
Merged

Create a git submodule setup#2
Zetison merged 8 commits intomainfrom
feat/submodules

Conversation

@Zetison
Copy link
Copy Markdown
Collaborator

@Zetison Zetison commented Apr 8, 2025

Use the git-submodule feature to create git-pointers to the repositories used in the developed nodes in the EnergyModelsLanguageInterfaces.jl-repository. This enables simpler work on these external repositories locally (changes in these are not tracked by the main repository) and one can then have a unified approach to finding and installing these models both locally and in the CI.

@Zetison Zetison added the enhancement New feature or request label Apr 8, 2025
@Zetison Zetison requested a review from JulStraus April 8, 2025 13:40
@Zetison Zetison self-assigned this Apr 8, 2025
Copy link
Copy Markdown
Member

@JulStraus JulStraus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me. I do not necessarily understand what the major impact is, but personally speaking, I think it is better that way

@Zetison
Copy link
Copy Markdown
Collaborator Author

Zetison commented Apr 9, 2025

Seems reasonable to me. I do not necessarily understand what the major impact is, but personally speaking, I think it is better that way

No major impact. Just more convenient and smooth.

@Zetison Zetison merged commit 1ba8941 into main Apr 9, 2025
3 checks passed
@Zetison Zetison deleted the feat/submodules branch April 9, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants